Code reviews don’t have to be complicated and obscure. When reviewing a pull request, consider the following:
- The pull request description adequately documents the context of the change.
- The functionality is good for both end-users and developers. Consider if the code does what the author claims it does, if edge cases are identified and addressed, and if there are any obvious security issues.
- The code is well-designed and integrates well with the rest of the codebase. Look for bad patterns.
- The code is not more complex than necessary. Can you understand the changes quickly or does the code need further explanation from the author?
- The change isn’t overengineered, and there are appropriate unit tests.
- Comments are clear and useful, mostly explaining why and not what.
- The code conforms to your team’s style guide. Any other issues should be considered nitpicks and optional to address.